Skip to content

Convert scores#181

Open
SimoneAriens wants to merge 8 commits intomainfrom
convert_scores
Open

Convert scores#181
SimoneAriens wants to merge 8 commits intomainfrom
convert_scores

Conversation

@SimoneAriens
Copy link
Collaborator

@SimoneAriens SimoneAriens commented Mar 11, 2026

Wrote a script to convert old comparisons in a database to our new scores. For now only for the striation marks, since the logic for the impression is not done yet.

There are two options:

  • Get the pairs to compare from the results.table that was generated by the matlab comparison
  • Generate new pairs, with an equal number of same-source and different-source pairs. We might want to update this in the future to take more different-source pairs, but for now I kept it simple

@SimoneAriens SimoneAriens marked this pull request as ready for review March 11, 2026 15:15
@github-actions
Copy link

Diff Coverage

Diff: origin/main..HEAD, staged and unstaged changes

  • packages/scratch-core/src/conversion/preprocess_striation/shear.py (100%)

Summary

  • Total: 1 line
  • Missing: 0 lines
  • Coverage: 100%

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
. 96% 88%
comparators 100% 100%
computations 100% 100%
container_models 99% 100%
conversion 96% 83%
conversion.export 100% 100%
conversion.filter 97% 89%
conversion.leveling 100% 100%
conversion.leveling.solver 100% 75%
conversion.plots 98% 88%
conversion.preprocess_impression 99% 91%
conversion.preprocess_striation 90% 62%
conversion.profile_correlator 96% 82%
conversion.surface_comparison 95% 86%
extractors 99% 75%
mutations 100% 100%
parsers 98% 80%
parsers.patches 89% 60%
preprocessors 99% 89%
processors 99% 100%
renders 98% 67%
utils 92% 75%
Summary 97% (3207 / 3295) 84% (339 / 402)

Minimum allowed line rate is 50%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant