Merged
Conversation
…e/scratch into cmc-pipeline-base
cfs-data
approved these changes
Mar 11, 2026
…e/scratch into cmc-pipeline-base
…ensicInstitute/scratch into feature/grids_for_cmc
vergep
requested changes
Mar 12, 2026
packages/scratch-core/src/conversion/surface_comparison/grid.py
Outdated
Show resolved
Hide resolved
packages/scratch-core/src/conversion/surface_comparison/grid.py
Outdated
Show resolved
Hide resolved
packages/scratch-core/tests/conversion/surface_comparison/test_grid.py
Outdated
Show resolved
Hide resolved
packages/scratch-core/tests/conversion/surface_comparison/test_grid.py
Outdated
Show resolved
Hide resolved
…e/scratch into feature/grids_for_cmc
Diff CoverageDiff: origin/main..HEAD, staged and unstaged changes
Summary
|
Minimum allowed line rate is |
vergep
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added grid generation to the cmc pipeline. Tried to stay as close as possible to the matlab version but also to keep it simple
I left the brute force logic of trying to squeeze as much valid data into the cells away for now. If really necessary we can add it later