Skip to content

grid for cmc added#178

Merged
SimoneAriens merged 21 commits intomainfrom
feature/grids_for_cmc
Mar 13, 2026
Merged

grid for cmc added#178
SimoneAriens merged 21 commits intomainfrom
feature/grids_for_cmc

Conversation

@SimoneAriens
Copy link
Collaborator

@SimoneAriens SimoneAriens commented Mar 10, 2026

added grid generation to the cmc pipeline. Tried to stay as close as possible to the matlab version but also to keep it simple

I left the brute force logic of trying to squeeze as much valid data into the cells away for now. If really necessary we can add it later

@SimoneAriens SimoneAriens requested review from cfs-data and vergep March 10, 2026 15:51
@SimoneAriens SimoneAriens marked this pull request as draft March 10, 2026 15:52
@SimoneAriens SimoneAriens marked this pull request as ready for review March 10, 2026 16:09
@SimoneAriens SimoneAriens requested a review from laurensWe March 11, 2026 08:53
Base automatically changed from cmc-pipeline-base to main March 11, 2026 13:46
@github-actions
Copy link

Diff Coverage

Diff: origin/main..HEAD, staged and unstaged changes

  • packages/scratch-core/src/conversion/surface_comparison/grid.py (100%)
  • packages/scratch-core/src/conversion/surface_comparison/models.py (100%)
  • packages/scratch-core/src/conversion/surface_comparison/pipeline.py (100%)

Summary

  • Total: 54 lines
  • Missing: 0 lines
  • Coverage: 100%

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
. 96% 88%
comparators 100% 100%
computations 100% 100%
container_models 99% 100%
conversion 96% 83%
conversion.export 100% 100%
conversion.filter 97% 89%
conversion.leveling 100% 100%
conversion.leveling.solver 100% 75%
conversion.plots 98% 88%
conversion.preprocess_impression 99% 91%
conversion.preprocess_striation 89% 58%
conversion.profile_correlator 96% 82%
conversion.surface_comparison 96% 89%
extractors 99% 75%
mutations 100% 100%
parsers 98% 80%
parsers.patches 89% 60%
preprocessors 99% 89%
processors 99% 100%
renders 98% 67%
utils 92% 75%
Summary 97% (3233 / 3321) 84% (346 / 410)

Minimum allowed line rate is 50%

@SimoneAriens SimoneAriens merged commit 3ce4b41 into main Mar 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants