Conversation
andre8244
reviewed
Mar 3, 2026
| } | ||
| }, | ||
| getOfflineInstanceTitle(instance) { | ||
| let nodeUiNameDisplay = ""; |
Contributor
There was a problem hiding this comment.
This logic can be removed by using getNodeLabel function
Contributor
Author
There was a problem hiding this comment.
good idea but in this context, I receive instance that is relevant to traefik, the code will change a lot
{
"digest": "sha256:22813a0f49acef039c30f5d5b0077bdd1962dd5cd4ba98015a5d73ae836e0860",
"flags": [
"rootless",
"core_module"
],
"id": "traefik3",
"logo": "",
"module": "traefik",
"node": "3",
"node_ui_name": "rtertret",
"source": "ghcr.io/nethserver/traefik",
"ui_name": "",
"ui_note": "",
"version": "4.2.0",
"node_id": "3"
}
Contributor
There was a problem hiding this comment.
const nodeLabel = instance.node_ui_name
? instance.node_ui_name + " (" + this.$t("common.node") + " " + instance.node + ")"
: this.$t("common.node") + " " + instance.node;
return nodeLabel;
… notifications display
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance user experience by notifying when Traefik instances are offline and adding relevant messages to the translation file. Improve error handling to track offline instances during certificate listing.
NethServer/dev#7842