Skip to content

fix(dpi): hardcoding the logging limit #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tbaile wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(dpi): hardcoding the logging limit #1544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/ns-dpi/files/dpi-nft
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ chain dpi_actions {
type filter hook prerouting priority filter + 10; policy accept;

{% if log_enabled -%}
ct label netify-blocked counter log prefix "DPI block: " limit rate {{ log_limit }}
ct label netify-blocked counter log prefix "DPI block: " limit rate 1/second
{% endif -%}
ct label netify-blocked counter reject
ct label bulk counter ip dscp set cs1 return
Expand All @@ -37,8 +37,7 @@ def generate_dpi():
e_uci = EUci()
template = Environment(loader=BaseLoader()).from_string(CHAIN)
render = template.render(
log_enabled=e_uci.get('dpi', 'config', 'log_blocked', dtype=bool, default=False),
log_limit=e_uci.get('firewall', 'ns_defaults', 'rule_log_limit', dtype=str, default='1/second')
log_enabled=e_uci.get('dpi', 'config', 'log_blocked', dtype=bool, default=False)
)
# save to nftables directory table-pre, only if the file is changed
file_path = '/usr/share/nftables.d/table-pre/dpi_actions.nft'
Expand Down
Loading