Intel additional AVX optimizations#1439
Closed
fhannebi wants to merge 3 commits intoNetflix:masterfrom
Closed
Conversation
fhannebi
commented
Sep 30, 2025
fhannebi
commented
- vif_avx512.c : vif_statistic_8_avx512() optimized with new avx512 intrinsics code
- integer_motion.c and motion_avx*.c : new avx2 and avx512 optimized functions which replace the corresponding C functions.
- integer_adm.c and adm_avx*.c : new avx2 and avx512 optimized functions which replace the corresponding C functions.
- Possibility to have further speedups by activating code in adm_avx512.c by setting the macros CALC_ANGLE1 and CALC_ANGLE2 at compilation.
- All these modifications have passed the unittest test cases.
Collaborator
|
Do you have benchmarks to share? |
kylophone
reviewed
Oct 22, 2025
libvmaf/src/feature/integer_adm.c
Outdated
| adm_decouple(buf, w, h, buf_stride, adm_enhn_gain_limit); | ||
| #if HAVE_AVX512 | ||
| if (flags & VMAF_X86_CPU_FLAG_AVX512) | ||
| adm_decouple_avx512(buf, w, h, buf_stride, adm_enhn_gain_limit, div_lookup); |
Collaborator
There was a problem hiding this comment.
Here and elsewhere. Please check the CPU flags during init and set optimized path via function pointer.
Author
There was a problem hiding this comment.
This is done with a new version of integer_adm.c provided in the commit 91942c5
Author
|
In e6ae1d0 commit: Modified the way picture.h is included in motion_avx512.c and motion_avx2.c to avoid errors of path finding in some configurations; |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
Closing, replaced by #1452. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.