Conversation
|
@amcp Can you review this? |
|
This PR is in very initial stages, basically brainstorming stage, not close to the merge stage. |
|
taking a look |
amcp
left a comment
amcp
left a comment
There was a problem hiding this comment.
minor comments and questions
| * @author vchella, pencal | ||
| */ | ||
| public interface NdBenchAbstractClient<W> { | ||
| public interface NdBenchAbstractClient<K, W> { |
There was a problem hiding this comment.
Please document the addition of parameter K. Also, is it OK not to narrow down the expected superclass/interfaces for K?
| * | ||
| * @author vchella, pencal | ||
| */ | ||
| public interface NdBenchAbstractClient<W> { |
There was a problem hiding this comment.
while we are in here, lets discuss the naming of parameter W. W stands for write because it is the type returned by writeSingle but it is not descriptive of what the type is. Can we rename W to PostImageType or am I thinking about it too much?
| @@ -0,0 +1,20 @@ | |||
| package com.netflix.ndbench.core; | |||
|
|
||
| import com.netflix.ndbench.api.plugin.NdBenchMonitor; | ||
|
|
||
| public interface NdBenchOperation<K> { |
There was a problem hiding this comment.
please add a classdoc. also, is there some functional interface we could make this interface extend? like for example Function or BiFunction?
| boolean isReadType(); | ||
|
|
||
| boolean isWriteType(); | ||
| } No newline at end of file |
There was a problem hiding this comment.
add a newline at the end of file
| import com.netflix.ndbench.api.plugin.NdBenchMonitor; | ||
|
|
||
| public interface NdBenchOperation<K> { | ||
| boolean process(NdBenchDriver driver, |
There was a problem hiding this comment.
please add javadoc on the spec
|
|
||
| try { | ||
| String value = ndBenchDriver.readSingle(key); | ||
| String value = "";//ndBenchDriver.readSingle(key); |
There was a problem hiding this comment.
why are these calls commented out?
| private final Map<K, String> data = Maps.newConcurrentMap(); | ||
|
|
||
| private DataGenerator dataGenerator; | ||
| private static final String ResultOK = "Ok"; |
There was a problem hiding this comment.
use all caps for a string constant?
2 participants
First attempt to make Key generators more generic instead of just Strings