Refactor disable requests query to async + RC actor lifecycle handling#833
Open
Refactor disable requests query to async + RC actor lifecycle handling#833
Conversation
0aaebb1 to
fabbad0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadAllDisableTaskExecutorsRequestsfrom blockingpreStart()to asyncpipeondefault-blocking-io-dispatcherwith retry (up to 5 attempts, 5s delay). Adata store timeout during this synchronous call caused
ActorInitializationException, whichMantisActorSupervisorStrategyhandles with permanentstop()— silentlykilling the
ExecutorStateManagerActorwith no recovery path.ResourceClusterActor— watch children, handleTerminatedby nulling stale refs (activating existing null-check error paths) andscheduling delayed re-creation.
Terminatedhandler inResourceClustersManagerActor— remove stale map entry and stop the surviving sibling actor so the full pair is cleanly recreated on nextrequest.
executorStateManagerInitFailure,childActorTerminated,childActorRecreated) withactorTypetags.Root Cause
ExecutorStateManagerActor.preStart()made a synchronous blocking gRPC call to DGW viamantisJobStore.loadAllDisableTaskExecutorsRequests(). When actual data store exceeded itsSLO:
CompletionException: DEADLINE_EXCEEDEDthrown inpreStart()ActorInitializationExceptionMantisActorSupervisorStrategy→SupervisorStrategy.stop()(permanent, no restart)ResourceClusterActorholds deadActorRef— all forwarded messages go to dead letters silently