Jedis binary API parity with string API #304
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the Jedis binary API to parity with the string API. Also, I refactored the client implementations so it requires less boilerplate code to add unimplemented methods going forward. Some other changes in this PR include a fix to the demo and support for hashtags with binary keys. Also, I made a change to reset the Jedis instance before returning it to the pool. This fixes an issue we encountered during testing, and is consistent with how the JedisPool operates.
While implementing this I noticed that the dual write client does not shadow all write commands, and compression is not consistently implemented. I will open a ticket for those existing issues if one doesn't exist.