fix: async bulk get transcoder fallback for plain keys in mixed-key requests#184
Merged
fix: async bulk get transcoder fallback for plain keys in mixed-key requests#184
Conversation
Sunjeet
force-pushed
the
fix/async-bulk-get
branch
from
5cdfdf0 to
6d922f8
Compare
Sunjeet
force-pushed
the
fix/async-bulk-get
branch
from
6d922f8 to
5939b06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug was introduced in my recent mixed-key refactor for get async bulk api - no known impact. Before that commit, mixed keys weren't supported at all in get async bulk api it was all-or-nothing based on hasHashedKey. So the window of exposure is only since that commit, and that change has not been released yet. Also, the only known use case for get async bulk api requesting mixed keys was passing a tc per call- so that didn't trigger this bug in tests.
For the bug to trigger, you need all four of these: