Skip to content

Escape all user input properly #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwin merged 1 commit into from
May 20, 2026
Merged

Escape all user input properly #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...sscontroltool-bundle/src/main/java/biz/netcentric/cq/tools/actool/ui/AcToolUiService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,9 @@ private void printInstallationLogsSection(HtmlWriter writer, RequestParameters r
return;
}

String sanitizedCurrentPath = escapeHtml4(currentPath);
for (AcToolExecution acToolExecution : acToolExecutions.values()) {
String linkToLog = currentPath + "?" + PARAM_SHOW_LOG_ID + "=" + acToolExecution.getId();
String linkToLog = sanitizedCurrentPath + "?" + PARAM_SHOW_LOG_ID + "=" + acToolExecution.getId();
String downloadLinkToLog = basePath + "/" + SUFFIX_DOWNLOAD_LOG + "?" + PARAM_SHOW_LOG_ID + "=" + acToolExecution.getId();
writer.tr();
writer.openTd();
Expand Down Expand Up @@ -610,7 +611,7 @@ private void printInstallationLogsSection(HtmlWriter writer, RequestParameters r
String logHtml = acHistoryService.getLogFromHistory(reqParams.showLogId, true, reqParams.showLogVerbose, MAX_LINE_WIDTH);

writer.openTable("logTable");
writer.tableHeader(logLabel, 1, false);
writer.tableHeader(logLabel, 1);
writer.tr();
writer.openTd();
writer.println(logHtml);
Expand Down
14 changes: 5 additions & 9 deletions accesscontroltool-bundle/src/main/java/biz/netcentric/cq/tools/actool/ui/HtmlWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,6 @@ void closeTable() {
pw.println("</table>");
}

void tableHeader(String title, int colspan, boolean escape) {
tr();
pw.print("<th " + (isTouchUi ? " is='coral-table-headercell'" : " class='content container'") + " colspan='" + colspan + "'>");
pw.print(escape ? escapeHtml4(title) : title);
pw.println("</th>");
closeTr();
}

void print(String s) {
pw.print(s);
}
Expand Down Expand Up @@ -88,7 +80,11 @@ void closeTr() {
}

void tableHeader(String title, int colspan) {
tableHeader(title, colspan, true);
tr();
pw.print("<th " + (isTouchUi ? " is='coral-table-headercell'" : " class='content container'") + " colspan='" + colspan + "'>");
pw.print(escapeHtml4(title));
pw.println("</th>");
closeTr();
}

}
Loading