Remove dependence on Object#blank? monkey patch
#607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nori patched `Object` to implement a `blank?` method, however it was removed in v2.7 (February 2024), so uses within this gem were now breaking without the method being implemented. Nori commit: savonrb/nori@780d01d CI was passing for Ruby < 3, since Nori v2.7 requires Ruby 3, however Ruby >= 3 was failing once it started using Nori v2.7.
cgunther
force-pushed
the
remove-object-blank-dependence
branch
from
2f77fad to
faa792a
Compare
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nori patched
Objectto implement ablank?method, however it was removed in v2.7 (February 2024), so uses within this gem were now breaking without the method being implemented.Nori commit:
savonrb/nori@780d01d
CI was passing for Ruby < 3, since Nori v2.7 requires Ruby 3, however Ruby >= 3 was failing once it started using Nori v2.7.