Skip to content

Fix incorrect attempt number displayed in dismiss_privacy_modal script #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DominikPalo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect attempt number displayed in dismiss_privacy_modal script #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/dismiss_privacy_modal.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ third_screen_dismissed=false
while [ $attempt -lt $max_attempts ]; do
# Check if PowerPoint is running
if pgrep -x "Microsoft PowerPoint" > /dev/null; then
echo "PowerPoint is running (attempt $attempt/$max_attempts)..."
echo "PowerPoint is running (attempt $((attempt + 1))/$max_attempts)..."
Copy link
Member

@jozefizso jozefizso Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it why should be display attempt + 1 value here instead of just the actual attempt?

Copy link
Member Author

@DominikPalo DominikPalo Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in the script, attempts are indexed from zero (0...<20) and the attempt value is incremented at the end of the while-do block (after echoing the current attempt to the user), so when the attempt variable is set to 0, it is actually the 1st attempt and so on. Another option would be to increase the attempt number at the beginning of the while-do block instead.

Check the screenshot in the PR – in the current implementation, it shows "attempt 0/20", which is nonsense.


# Handle first screen if not yet dismissed
if [[ "$first_screen_dismissed" == "false" ]]; then
Expand Down
Loading