Skip to content

refactor: update description of update tools#155

Merged
cgrinds merged 3 commits into
mainfrom
hl_ci
Jun 23, 2026
Merged

refactor: update description of update tools#155
cgrinds merged 3 commits into
mainfrom
hl_ci

Conversation

@Hardikl

@Hardikl Hardikl commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 17, 2026 09:50
@cla-bot cla-bot Bot added the cla-signed label Jun 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors and clarifies tool interfaces and user-facing tool descriptions, primarily around “update” operations, and adjusts integration tests to better match the intended natural-language prompts and cleanup behavior.

Changes:

  • Introduces a dedicated SnapshotPolicyCreate parameter type and updates the snapshot policy create handler to use it.
  • Updates multiple tool description strings to be more explicit about what “update” supports.
  • Tweaks integration tests (prompt phrasing, cleanup ordering/expectations) and improves retry logging context.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tool/tool.go Adds SnapshotPolicyCreate; adjusts NetworkIPInterface.Scope JSON tag behavior.
server/Snapshotpolicy.go Switches create snapshot policy handler + converter to use SnapshotPolicyCreate.
integration/test/tools_test.go Adds original user input to retry warning logs for better debugging.
integration/test/lun_test.go Adjusts expected error for LUN cleanup to reflect successful deletion.
integration/test/iscsi_test.go Fixes test prompt phrasing (“disable” vs “disabled”).
integration/test/igroup_test.go Reorders cleanup steps and fixes iSCSI prompt phrasing.
descriptions/descriptions.go Expands/clarifies update-tool descriptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tool/tool.go
Comment thread descriptions/descriptions.go
Comment thread descriptions/descriptions.go
Copilot AI review requested due to automatic review settings June 17, 2026 12:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comment thread integration/test/lun_test.go
@cgrinds cgrinds merged commit 54dd997 into main Jun 23, 2026
24 checks passed
@cgrinds cgrinds deleted the hl_ci branch June 23, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants