Skip to content

refactor: adapt tests to use InsecureTLS()#153

Merged
cgrinds merged 1 commit into
mainfrom
cbg-tests
Jun 16, 2026
Merged

refactor: adapt tests to use InsecureTLS()#153
cgrinds merged 1 commit into
mainfrom
cbg-tests

Conversation

@cgrinds

@cgrinds cgrinds commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 16, 2026 15:03
@cla-bot cla-bot Bot added the cla-signed label Jun 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors integration tests to use the Poller.InsecureTLS() helper rather than directly reading UseInsecureTLS, aligning tests with the current Poller configuration model (where UseInsecureTLS is a pointer and “unset” must be handled).

Changes:

  • Replace poller.UseInsecureTLS with poller.InsecureTLS() when configuring tls.Config.InsecureSkipVerify across several integration tests.
  • Standardize integration tests on the same TLS decision logic used elsewhere in the codebase.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
integration/test/volume_test.go Switch TLS skip-verify flag to poller.InsecureTLS()
integration/test/snapshot_test.go Switch TLS skip-verify flag to poller.InsecureTLS()
integration/test/snapshot_policy_test.go Switch TLS skip-verify flag to poller.InsecureTLS()
integration/test/qos_volume_test.go Switch TLS skip-verify flag to poller.InsecureTLS()
integration/test/igroup_test.go Switch TLS skip-verify flag to poller.InsecureTLS()
integration/test/dns_test.go Switch TLS skip-verify flag to poller.InsecureTLS()
integration/test/cluster_test.go Switch TLS skip-verify flag to poller.InsecureTLS()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cgrinds cgrinds merged commit fd2592c into main Jun 16, 2026
18 of 24 checks passed
@cgrinds cgrinds deleted the cbg-tests branch June 16, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants