Skip to content

feat: handled dns test with skip validation#149

Merged
Hardikl merged 2 commits into
mainfrom
hl_dns
Jun 15, 2026
Merged

feat: handled dns test with skip validation#149
Hardikl merged 2 commits into
mainfrom
hl_dns

Conversation

@Hardikl

@Hardikl Hardikl commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for ONTAP DNS configuration creation with optional “skip config validation”, and updates REST/client + integration tests to cover the new behavior.

Changes:

  • Extend DNS tool/API models with skip_config_validation and make DNS domains/servers optional in tool schema.
  • Wire the new flag through server → ontap model mapping and adjust DNS REST calls’ response handling.
  • Update integration tests for DNS/NFS error expectations and expand DNS test coverage (success with skip validation, failure without it).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tool/tool.go Adds SkipConfigValidation to DNS tool params; makes domains/servers optional via omitzero.
server/dns.go Maps SkipConfigValidation into the ONTAP DNS config request.
rest/dns.go Removes job-body buffering/handling; relies on status-code checking for DNS create/delete.
ontap/ontap.go Extends DNSConfig with SkipConfigValidation and updates JSON/jsonschema tags.
integration/test/nfs_service_test.go Updates expected error strings and adjusts “Clean SVM” expectation.
integration/test/dns_test.go Expands DNS tests to cover skip-validation behavior; refactors DNS verification helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tool/tool.go Outdated
Comment thread integration/test/dns_test.go
Comment thread integration/test/dns_test.go
@Hardikl Hardikl merged commit 078d56e into main Jun 15, 2026
19 of 23 checks passed
@Hardikl Hardikl deleted the hl_dns branch June 15, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants