Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for ONTAP DNS configuration creation with optional “skip config validation”, and updates REST/client + integration tests to cover the new behavior.
Changes:
- Extend DNS tool/API models with
skip_config_validationand make DNS domains/servers optional in tool schema. - Wire the new flag through server → ontap model mapping and adjust DNS REST calls’ response handling.
- Update integration tests for DNS/NFS error expectations and expand DNS test coverage (success with skip validation, failure without it).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tool/tool.go | Adds SkipConfigValidation to DNS tool params; makes domains/servers optional via omitzero. |
| server/dns.go | Maps SkipConfigValidation into the ONTAP DNS config request. |
| rest/dns.go | Removes job-body buffering/handling; relies on status-code checking for DNS create/delete. |
| ontap/ontap.go | Extends DNSConfig with SkipConfigValidation and updates JSON/jsonschema tags. |
| integration/test/nfs_service_test.go | Updates expected error strings and adjusts “Clean SVM” expectation. |
| integration/test/dns_test.go | Expands DNS tests to cover skip-validation behavior; refactors DNS verification helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cgrinds
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.