Conversation
# Conflicts: # go.mod
There was a problem hiding this comment.
Pull request overview
This PR introduces optional OAuth-style bearer JWT validation for the MCP HTTP endpoint, driven by new Defaults.auth_token and Defaults.jwks_uri YAML configuration, and updates the sample config and Go module dependencies accordingly.
Changes:
- Adds JWT verification and JWKS fetch/cache logic to the HTTP server request path.
- Extends YAML config schema to allow
auth_tokenandjwks_uriunderDefaults. - Updates
ontap-example.yamland addsgithub.com/golang-jwt/jwt/v5dependency.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
server/server.go |
Adds OAuth/JWT enforcement in the HTTP handler plus JWKS fetching/caching and JWK→RSA key conversion. |
config/config.go |
Adds auth_token and jwks_uri fields to the Poller struct used by Defaults. |
ontap-example.yaml |
Documents the new Defaults.auth_token and Defaults.jwks_uri settings. |
go.mod |
Adds github.com/golang-jwt/jwt/v5 dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,9 @@ | |||
| # See https://netapp.github.io/ontap-mcp/nightly/ | |||
| McpAuth: | |||
Contributor
Author
There was a problem hiding this comment.
Just Auth or OAuth may treated as one of authentication supported on ontap as mentioned here: https://netapp.github.io/ontap-mcp/nightly/prepare-ontap/#authentication
# Conflicts: # go.sum # integration/go.mod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding these in ontap.yaml