Support flexcache volume creation with GCNV volume tool#32
Open
gnaveen-netapp wants to merge 1 commit into
Open
Support flexcache volume creation with GCNV volume tool#32gnaveen-netapp wants to merge 1 commit into
gnaveen-netapp wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds first-class FlexCache cache-volume support to the GCNV volume tools (via cacheParameters), relaxes ONTAP preflight validation so PATCH body templates are treated as illustrative, and expands the ONTAP API index + GEMINI guidance to better steer users through supported workflows.
Changes:
- Add
cacheParametersschema support togcnv_volume_create/gcnv_volume_update, and plumb it through the volume handlers (including updateMask support). - Update
preflightValidate()to enforce index body templates forPOSTonly (PATCH templates are illustrative), with added unit tests. - Enrich
ontap-api-index.jsonwith improved hints and example bodies, and expandGEMINI.mdguidance for FlexCache / hybrid replication workflows.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/ontap-preflight-validator.ts | Enforce index body templates for POST only; keep requiredBody enforcement. |
| src/utils/ontap-preflight-validator.test.ts | Add regression tests for PATCH illustrative templates and requiredBody behavior. |
| src/tools/volume-tools.ts | Introduce cacheParameters Zod schema and expose it on create/update volume tools. |
| src/tools/handlers/volume-handler.ts | Pass cacheParameters on create; support patching it via updateMask. |
| src/tools/handlers/volume-handler.test.ts | Add tests covering create/update behavior for cacheParameters. |
| src/resources/ontap-api-index.json | Add/adjust hints and example bodies across many ONTAP endpoints. |
| GEMINI.md | Add authoritative-doc guidance and clarify FlexCache vs hybrid replication tool usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gnaveen-netapp
force-pushed
the
flexcacheParam
branch
from
73fbb49 to
c9b585a
Compare
gnaveen-netapp
force-pushed
the
flexcacheParam
branch
from
2db8b44 to
9ee39b3
Compare
gnaveen-netapp
force-pushed
the
flexcacheParam
branch
from
9ee39b3 to
a2fe9e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant improvements to both the documentation and the ONTAP API index. The main focus is on clarifying and expanding guidance for GCNV workflows (especially FlexCache and hybrid replication), and greatly enhancing the ONTAP API index with detailed hints and example request bodies for update and delete operations. These changes will help users and developers better understand the correct API usage and supported features.
Documentation Updates:
GEMINI.mdclarifying that official GCNV documentation is the authoritative source for supported features, and provided explicit mapping guidance from documentation workflows to MCP tools and parameters.GEMINI.md, including correct tool usage and cross-mode support.