Convert port to string for SCP command building#18
Open
jhollowe wants to merge 1 commit intoNetAngels:masterfrom
Open
Convert port to string for SCP command building#18jhollowe wants to merge 1 commit intoNetAngels:masterfrom
jhollowe wants to merge 1 commit intoNetAngels:masterfrom
Conversation
Author
|
PR #13 is better, I just wanted to put in a quick fix and draw attention to this issue and that its solution is easy to implement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the port is an int, scp fails due to
scp_command's finalb_listtrying to convert the int to a string which does not work.This mirrors what
ssh_commanddoes.e.g. with a port number (before fix)