Skip to content

Add Makefile #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lborguetti wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Makefile #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
950d6a0
Added Makefile
lucianobfaustino Mar 22, 2017
bac8f81
Added target all in .PHONY
lucianobfaustino Mar 22, 2017
efb003d
Updated README.md
lucianobfaustino Mar 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
.PHONY: deps install all

ifndef NASHPATH
$(error $$NASHPATH is not set)
endif

ifndef GOPATH
$(error $$GOPATH is not set)
endif

all: deps install

deps:
go get github.com/c0defellas/enzo/cmd/...

install:
Copy link
Contributor

@katcipis katcipis Mar 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it not be a good idea to remove a previous install before ? some older files may remain on the dir as the project evolves. new code that wrongly imports old stuff would even work after make install since the old file would still be present on the system.

Copy link
Contributor Author

@lborguetti lborguetti Mar 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't know this PR is useful, sorry 🤕

Copy link
Contributor

@katcipis katcipis Mar 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is useful 👍

Copy link
Collaborator

@i4ki i4ki Mar 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this install rule odd. I agree with @katcipis that this could leave the install in an inconsistent state... or be harmful in case of overwritten user's files.

I think the only required rule in the Makefile is "deps" for now.

mkdir -p $(NASHPATH)/lib/nashcomplete
cp all.sh $(NASHPATH)/lib/nashcomplete
cp common.sh $(NASHPATH)/lib/nashcomplete
cp deps.sh $(NASHPATH)/lib/nashcomplete
cp files.sh $(NASHPATH)/lib/nashcomplete
cp history.sh $(NASHPATH)/lib/nashcomplete
cp kill.sh $(NASHPATH)/lib/nashcomplete
cp programs.sh $(NASHPATH)/lib/nashcomplete
cp systemd.sh $(NASHPATH)/lib/nashcomplete
7 changes: 4 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ The name says everything.
First clone the repository:

```sh
λ> mkdir -p $NASHPATH+"/lib"
λ> cd $NASHPATH+"/lib"
λ> git clone git@github.com:tiago4orion/nashcomplete.git
λ> git clone git@github.com:NeowayLabs/nashcomplete.git
Copy link
Collaborator

@i4ki i4ki Mar 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of install, maybe shows how to use nashget to get the same result.

λ> cd nashcomplete
λ> make

```

To setup the auto complete you only need to add an import line into your init script.
Expand Down