Skip to content

Only reset XP down to sergeant inbetween JGR rounds #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DESTROYGIRL wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only reset XP down to sergeant inbetween JGR rounds #1627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/game/shared/neo/neo_gamerules.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3094,9 +3094,9 @@ void CNEORules::ResetJGR()
for (int i = 1; i <= gpGlobals->maxClients; ++i)
{
auto pPlayer = static_cast<CNEO_Player *>(UTIL_PlayerByIndex(i));
if (pPlayer)
if (pPlayer && pPlayer->m_iXP.Get() > 10)
{
pPlayer->m_iXP.GetForModify() = 0;
pPlayer->m_iXP.GetForModify() = 10;
Copy link
Contributor

@sunzenshen sunzenshen Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could maybe use the constant XP_SERGEANT from src/game/shared/neo/neo_weapon_loadout.h

Copy link
Contributor Author

@DESTROYGIRL DESTROYGIRL Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those should probably be moved into neo_enums or something because I did not see them and they don't seem to be used inside of gamerules for xp stuff currently

}
}
}
Expand Down