Skip to content

Fix Android date picker ignoring past (and future) dates on workout/cardio logging #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix Android date picker ignoring past (and future) dates on workout/cardio logging #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd3cf6b
Initial plan
Copilot Apr 28, 2026
92f6162
Fix DateTimePicker handlers ignoring past dates on Android by checkin…
Copilot Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions my-expo-app/components/CardioTracker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,12 @@ const CardioTracker = () => {
return `${String(date.getHours()).padStart(2, '0')}:${String(date.getMinutes()).padStart(2, '0')}`;
};

const onAddDateChange = (_event: DateTimePickerEvent, date?: Date) => {
const onAddDateChange = (event: DateTimePickerEvent, date?: Date) => {
if (Platform.OS === 'android') {
setShowAddDatePicker(false);
}

if (date) {
if (event.type === 'set' && date) {
setSelectedDateTime((prevDateTime) => {
const nextDateTime = new Date(prevDateTime);
nextDateTime.setFullYear(date.getFullYear(), date.getMonth(), date.getDate());
Expand All @@ -97,12 +97,12 @@ const CardioTracker = () => {
}
};

const onAddTimeChange = (_event: DateTimePickerEvent, date?: Date) => {
const onAddTimeChange = (event: DateTimePickerEvent, date?: Date) => {
if (Platform.OS === 'android') {
setShowAddTimePicker(false);
}

if (date) {
if (event.type === 'set' && date) {
setSelectedDateTime((prevDateTime) => {
const nextDateTime = new Date(prevDateTime);
nextDateTime.setHours(date.getHours(), date.getMinutes(), 0, 0);
Expand All @@ -111,12 +111,12 @@ const CardioTracker = () => {
}
};

const onEditDateChange = (_event: DateTimePickerEvent, date?: Date) => {
const onEditDateChange = (event: DateTimePickerEvent, date?: Date) => {
if (Platform.OS === 'android') {
setShowEditDatePicker(false);
}

if (date) {
if (event.type === 'set' && date) {
setEditDateTime((prevDateTime) => {
const nextDateTime = new Date(prevDateTime);
nextDateTime.setFullYear(date.getFullYear(), date.getMonth(), date.getDate());
Expand All @@ -125,12 +125,12 @@ const CardioTracker = () => {
}
};

const onEditTimeChange = (_event: DateTimePickerEvent, date?: Date) => {
const onEditTimeChange = (event: DateTimePickerEvent, date?: Date) => {
if (Platform.OS === 'android') {
setShowEditTimePicker(false);
}

if (date) {
if (event.type === 'set' && date) {
setEditDateTime((prevDateTime) => {
const nextDateTime = new Date(prevDateTime);
nextDateTime.setHours(date.getHours(), date.getMinutes(), 0, 0);
Expand Down
16 changes: 8 additions & 8 deletions my-expo-app/components/InputWorkout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,12 +217,12 @@ const InputWorkout = () => {
};
}

const onAddDateChange = (_event: DateTimePickerEvent, date?: Date) => {
const onAddDateChange = (event: DateTimePickerEvent, date?: Date) => {
if (Platform.OS === 'android') {
setShowAddDatePicker(false);
}

if (date) {
if (event.type === 'set' && date) {
setSelectedDateTime((prevDateTime) => {
const nextDateTime = new Date(prevDateTime);
nextDateTime.setFullYear(date.getFullYear(), date.getMonth(), date.getDate());
Expand All @@ -231,12 +231,12 @@ const InputWorkout = () => {
}
};

const onAddTimeChange = (_event: DateTimePickerEvent, date?: Date) => {
const onAddTimeChange = (event: DateTimePickerEvent, date?: Date) => {
if (Platform.OS === 'android') {
setShowAddTimePicker(false);
}

if (date) {
if (event.type === 'set' && date) {
setSelectedDateTime((prevDateTime) => {
const nextDateTime = new Date(prevDateTime);
nextDateTime.setHours(date.getHours(), date.getMinutes(), 0, 0);
Expand All @@ -245,12 +245,12 @@ const InputWorkout = () => {
}
};

const onEditDateChange = (_event: DateTimePickerEvent, date?: Date) => {
const onEditDateChange = (event: DateTimePickerEvent, date?: Date) => {
if (Platform.OS === 'android') {
setShowEditDatePicker(false);
}

if (date) {
if (event.type === 'set' && date) {
setEditDateTime((prevDateTime) => {
const nextDateTime = new Date(prevDateTime);
nextDateTime.setFullYear(date.getFullYear(), date.getMonth(), date.getDate());
Expand All @@ -259,12 +259,12 @@ const InputWorkout = () => {
}
};

const onEditTimeChange = (_event: DateTimePickerEvent, date?: Date) => {
const onEditTimeChange = (event: DateTimePickerEvent, date?: Date) => {
if (Platform.OS === 'android') {
setShowEditTimePicker(false);
}

if (date) {
if (event.type === 'set' && date) {
setEditDateTime((prevDateTime) => {
const nextDateTime = new Date(prevDateTime);
nextDateTime.setHours(date.getHours(), date.getMinutes(), 0, 0);
Expand Down