Skip to content

Port to POSIX#1

Open
trn1ty wants to merge 8 commits into
NeilInnes:masterfrom
trn1ty:master
Open

Port to POSIX#1
trn1ty wants to merge 8 commits into
NeilInnes:masterfrom
trn1ty:master

Conversation

@trn1ty
Copy link
Copy Markdown

@trn1ty trn1ty commented May 6, 2026

It does the same thing, better, in 75% of the code, and is compatible with more shells. However I haven't tested it. You should probably test it before accepting the PR. I did this while very tired so apologies if I made a silly mistake.

@NeilInnes
Copy link
Copy Markdown
Owner

Thanks - on a quick glance this looks good, maybe needs a bit more output so keep the user informed. I'll give this a good check over 👍

@trn1ty
Copy link
Copy Markdown
Author

trn1ty commented May 6, 2026

It has about as much output as before. set -e makes it terminate on error, and the various ls >/dev/null constructs are silent on success but report an error on failure. This also means most of the localization is provided by the operating system.

Much of the debugging messages were communicating things already known to the user or implied by the function of the program, so where things weren't obvious I pushed the information to stderr. The biggest spot of information is in dancing around finding the bootloader path, but the situation where someone has a uConsole OS without proper bootloader directories is rather unlikely, and the error message would still be helpful to them by showing them the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants