Various fixes/tweaks for unit tests.#5275
Merged
out-of-phaze merged 1 commit intoNebulaSS13:devfrom Feb 1, 2026
Merged
Conversation
Contributor
MistakeNot4892
commented
Jan 15, 2026
MistakeNot4892
commented
- Allows bodytypes to skip organ validation (needed for bodytypes that don't implement a full set of organs, like specific prosthetic models).
- Makes category generation more explicit about failures in fusion reaction info.
- Fixes a copypaste error.
out-of-phaze
previously requested changes
Jan 23, 2026
|
|
||
| var/list/tail_data = has_limbs[BP_TAIL] | ||
| if(tail_data) | ||
| if(tail_data && !TYPE_IS_ABSTRACT(src)) |
Member
There was a problem hiding this comment.
i don't think abstract bodytypes can even be instantiated or validated, can they? did this fix a real practical issue? because afaict it should never be triggered.
Contributor
Author
There was a problem hiding this comment.
Oh, no, I just chucked it in there in case.
MistakeNot4892
force-pushed
the
organ_validation_test
branch
from
12b7c71 to
55984dd
Compare
out-of-phaze
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.