Add AUDIT.md: audit report for NQ-Swap backend engineer submission#1
Add AUDIT.md: audit report for NQ-Swap backend engineer submission#1RolandDivine wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07762e072e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - `transactions` is partitioned by timestamp. | ||
| - A helper function exists to create a daily partition. |
There was a problem hiding this comment.
Treat daily partitioning as unimplemented
This section gives storage credit for daily partitioning, but the repository never actually turns it on. init.sql creates a transactions_default partition and defines create_daily_partition(), yet a repo-wide search shows no trigger, cron job, or application call that invokes that function from docker-compose.yml, startup code, or src/. In a clean deployment every insert will land in the default partition, so the assignment's daily partitioning requirement is effectively unmet rather than partially satisfied.
Useful? React with 👍 / 👎.
Motivation
Description
AUDIT.mdcontaining a detailed review for candidate "Varun" that covers ingestion, sandwich detection, storage/partitioning, API, RPC failover, re-org strategy, scores, verdict, and actionable remediation suggestions.Testing
Codex Task