Skip to content

Conversation

@ZigTag
Copy link
Contributor

@ZigTag ZigTag commented Jan 19, 2026

I could've downgraded bestzip to version v1, but that seemed like a bad idea on an already 4-year-old package, so I switched us over to using a script using cross-zip instead.

@ZigTag ZigTag requested a review from a team as a code owner January 19, 2026 18:14
@ZigTag ZigTag changed the title Replace bestzip with cross-zip Replace bestzip with cross-zip script Jan 19, 2026
@Navigraph Navigraph deleted a comment from navigraph-bot Jan 19, 2026
@ZigTag ZigTag force-pushed the workflow/shorten-artifact branch from af13dd2 to 7223421 Compare January 19, 2026 18:28
@ZigTag ZigTag force-pushed the workflow/shorten-artifact branch from 39f7540 to 732c838 Compare January 19, 2026 18:31
Copy link
Contributor

@SkySails SkySails left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does look good!

Could I suggest that we move this zip into the dist folder instead, and update the release workflows? We generally keep "packaged" content in dist, not the root. Seems like we went a different route here for some reason, likely not intentional.

Also, we need to update the title I think 😉

@ZigTag ZigTag changed the title Replace bestzip with cross-zip script Simplify artifact file structure Jan 20, 2026
@ZigTag ZigTag requested a review from SkySails January 20, 2026 20:43
@ZigTag ZigTag merged commit 6c2fbce into main Jan 21, 2026
5 checks passed
@ZigTag ZigTag deleted the workflow/shorten-artifact branch January 21, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants