Skip to content

같은 pdf 페이지 리렌더링시 발생하는 에러를 catch처리 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2-one-week merged 2 commits into from
Nov 21, 2025
Merged

같은 pdf 페이지 리렌더링시 발생하는 에러를 catch처리 #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4532bd5
[#190] 동일한 페이지에 다시 렌더링이 발생해서 생기는 에러의 경우 이전 렌더링에서의 에러를 무시
keemhyunseok Jul 29, 2025
f64ab4f
Create easy-loops-admire.md
keemhyunseok Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/easy-loops-admire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@naverpay/react-pdf": patch
---

pdfjs-dist의 버전을 최신화합니다

PR: [pdfjs-dist의 버전을 최신화합니다](https://github.com/NaverPayDev/pie/pull/191)
15 changes: 15 additions & 0 deletions packages/react-pdf/src/components/page/Canvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ import type {RenderTask} from 'pdfjs-dist'

export const PageCanvas = memo(function PageCanvas() {
const pageRenderTask = useRef<RenderTask>()

const renderingId = useRef(0)

const {page, viewport: renderViewport, scale} = usePdfPageContext()

const drawCanvas = useCallback(
Expand All @@ -23,6 +26,9 @@ export const PageCanvas = memo(function PageCanvas() {

pageRenderTask.current?.cancel()

// Generate new rendering ID (for tracking the last request)
const currentRenderingId = ++renderingId.current

const canvasViewport = page.getViewport({scale: scale * getPixelRatio()})

canvas.width = canvasViewport.width
Expand All @@ -32,6 +38,15 @@ export const PageCanvas = memo(function PageCanvas() {
canvas.style.height = `${Math.floor(renderViewport.height)}px`

pageRenderTask.current = page.render({canvasContext, viewport: canvasViewport})

pageRenderTask.current.promise.catch((error) => {
// Ignore errors if they are not from the latest rendering
if (currentRenderingId !== renderingId.current) {
return
}

throw error
})
})
},
[page, renderViewport.height, renderViewport.width, scale],
Expand Down