Skip to content

[CI] commithelper-go 정식 배포 시 upload-assets job이 실행되지 않는 이슈 디버깅 및 수정 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yujeong-jeon merged 1 commit into from
Feb 25, 2026
Merged

[CI] commithelper-go 정식 배포 시 upload-assets job이 실행되지 않는 이슈 디버깅 및 수정 #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
outputs:
published: ${{ steps.publish_release.outputs.published || steps.publish_canary.outputs.published || steps.publish_rc.outputs.published }}
commithelperGoWillBePublished: ${{ steps.checkCommitHelperGo.outputs.commithelperGoWillBePublished }}
packageVersion: ${{ steps.checkCommitHelperGo.outputs.publishedVersion || steps.getCommitHelperGoVersion.outputs.packageVersion }}
packageVersion: ${{ steps.checkCommitHelperGo.outputs.publishedVersion }}
env:
SKIP_COMMIT_HELPER_POSTINSTALL: 1
GITHUB_TOKEN: ${{ secrets.ACTION_TOKEN }}
Expand Down Expand Up @@ -75,12 +75,6 @@ jobs:
- name: installDependencies
run: pnpm install --frozen-lockfile

- name: getCommitHelperGoVersion
id: getCommitHelperGoVersion
run: |
packageVersion=$(cat packages/commithelper-go/package.json | jq -r '.version')
echo "packageVersion=$packageVersion" >> $GITHUB_OUTPUT

- name: buildNodePackages
run: pnpm build

Expand Down Expand Up @@ -132,7 +126,11 @@ jobs:
id: checkCommitHelperGo
if: always()
run: |
echo "publish_release publishedPackages: '${{ steps.publish_release.outputs.publishedPackages }}'"
echo "publish_canary publishedPackages: '${{ steps.publish_canary.outputs.publishedPackages }}'"
echo "publish_rc publishedPackages: '${{ steps.publish_rc.outputs.publishedPackages }}'"
publishedPackages='${{ steps.publish_release.outputs.publishedPackages || steps.publish_canary.outputs.publishedPackages || steps.publish_rc.outputs.publishedPackages }}'
echo "resolved publishedPackages: '$publishedPackages'"
if [ -z "$publishedPackages" ] || [ "$publishedPackages" == "null" ]; then
echo "commithelperGoWillBePublished=false" >> $GITHUB_OUTPUT
else
Expand All @@ -149,7 +147,7 @@ jobs:

upload-assets:
needs: release
if: needs.release.outputs.published == 'true' && needs.release.outputs.commithelperGoWillBePublished == 'true'
if: always() && needs.release.outputs.published == 'true' && needs.release.outputs.commithelperGoWillBePublished == 'true'
uses: ./.github/workflows/release-asset.yaml
with:
package: '@naverpay/commithelper-go'
Expand Down