Refactor project storage to fix resource leaks and optimize file handling#13
Closed
Pacsfury wants to merge 4 commits into
Closed
Refactor project storage to fix resource leaks and optimize file handling#13Pacsfury wants to merge 4 commits into
Pacsfury wants to merge 4 commits into
Conversation
Signed-off-by: Pacsfury <pacsfury12@gmail.com>
Updated load_project function to return a tuple instead of a list. Modified save_project function to include mode and encoding parameters. Signed-off-by: Pacsfury <pacsfury12@gmail.com>
Signed-off-by: Pacsfury <pacsfury12@gmail.com>
Signed-off-by: Pacsfury <pacsfury12@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the project's saving and loading system (save_project and load_project functions) by fixing resource management bugs and removing redundant code.
The original implementation opened the file streams twice (via filedialog and then again with a redundant open() call) and contained unnecessary manual close() statements inside context managers.
Key changes:
Resource Leak Fix (with open closes automatically, no need for close() )
Clean Context Management
Safer File Open Modes (explicit mode and encoding)
Readability Improvement (Replaced the nested if file: blocks with guard clauses (if not file: return None) )
I didn't change anything else.