fix(validator): reject numeric character references with no digits (&#; and &#x;)#840
Open
sravan27 wants to merge 1 commit into
Open
fix(validator): reject numeric character references with no digits (&#; and &#x;)#840sravan27 wants to merge 1 commit into
sravan27 wants to merge 1 commit into
Conversation
validateNumberAmpersand returned success on a ';' immediately following '&#' or '&#x', so XMLValidator.validate marked '<r>&#x;</r>' and '<r>&#;</r>' as valid. XML 1.0 requires at least one digit in a CharRef.
Member
|
@sarahdayan , please try with 'fast-xml-validator' and let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
XMLValidator.validatereports malformed numeric character references as valid:Per the XML 1.0
CharRefproduction, a numeric reference must contain at least one digit (&#[0-9]+;or&#x[0-9a-fA-F]+;).&#;and&#x;have none.Cause
src/validator.js,validateNumberAmpersand: the scan loop checks for;before requiring any digit, so a;immediately following&#or&#xreturns a success index with zero digits consumed.