Conversation
add OFX::Host::Param::StrChoiceInstance add ImageEffect properties : - kOfxImageEffectPropCudaStreamSupported - kOfxImageEffectPropMetalRenderSupported add Render properties : - kOfxImageEffectPropMetalEnabled - kOfxImageEffectPropCudaStream - kOfxImageEffectPropMetalCommandQueue correct a use after free error in kOfxActionUnload
r2d3
force-pushed
the
feature/resolve_strchoice
branch
from
11715df to
a9aebbc
Compare
devernay
left a comment
devernay
left a comment
There was a problem hiding this comment.
LGTM!
Thank you David!
Since you seem to be developing on resolve, could you take a look at why the plugins in openfx-misc don't load/run? I found no way to debug this. Probably some openfx stuff that doesn't please Resolve.
Also, we get regular requests for binaries of denoisesharpen (from openfx-misc) for Resolve, do you think you could contribute this?
| # endif | ||
| stat = (*_pluginHandle)->mainEntry(kOfxActionUnload, 0, 0, 0); | ||
| # ifdef OFX_DEBUG_ACTIONS | ||
| std::cout << "OFX: "<<op->pluginIdentifier<<"("<<(void*)op<<")->"<<kOfxActionUnload<<"()->"<<StatStr(stat)<<std::endl; |
There was a problem hiding this comment.
It's it still a draft or is it ready to merge?
There was a problem hiding this comment.
It is still a draft as I am not sure of the way StrChoiceInstance::notify is supposed to work.
There was a problem hiding this comment.
About openfx-misc plugins, what is the issue ? They do not load on macOS and Windows and Linux or a specific OS and specific versions of Resolve ?
|
ready? |
Not yet. I am putting it into action and |
2 participants
add
OFX::Host::Param::StrChoiceInstanceadd ImageEffect properties :
kOfxImageEffectPropCudaStreamSupportedkOfxImageEffectPropMetalRenderSupportedadd Render properties :
kOfxImageEffectPropMetalEnabledkOfxImageEffectPropCudaStreamkOfxImageEffectPropMetalCommandQueuecorrect a use after free error in
kOfxActionUnload