feat: configure tests workflow#132
Merged
Merged
Conversation
Member
Author
|
@simonhamp @steven-fox any idea why the tests don't pass? I tried passing default values to |
Collaborator
I think you're on the right issue - this is probably a env key problem (anystack keys included). Let me pull this branch and see if I can tweak things to get it working in a sensible manner. The tests were admittedly done with haste as the priority, so taking a moment to set things up differently is probably warranted. |
1ac64ab to
6128cb0
Compare
steven-fox
approved these changes
May 12, 2025
Collaborator
|
@SRWieZ I added testing env vars to phpunit.xml and the workflow is now working correctly. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
.github/workflows/tests.yamlworkflow supports unit and feature tests, using Composer dependency caching and an in-memory SQLite database. It compiles assets and generates an application key before test execution.The
composer.jsonnow includesdoctrine/dbal(version^3.9) because otherwise it would not migrate on my machine.