V1 docs#111
Conversation
shanerbaner82
requested review from
PeteBishwhip,
SRWieZ,
gwleuverink and
simonhamp
PeteBishwhip
left a comment
PeteBishwhip
left a comment
There was a problem hiding this comment.
Just a few comments and questions. Overall looks good. The URL's in deep-links are my biggest concern. Perhaps we should be using example.net instead?
| ### Laravel | ||
| #### For Windows | ||
| ```shell | ||
| set JAVA_HOME=C:\Program Files\Microsoft\jdk-17.0.8.7-hotspot |
There was a problem hiding this comment.
I'm wondering if this can be replaced with a programatic approach? I'm not sure everyone will have 17.0.8.7 specifically? Not a blocker, just an observation.
Is it possible this isn't required if JAVA_HOME is already set in the Windows Env Variables?
|
|
||
| For example: | ||
| ```dotenv | ||
| https://bifrost.tech/property/456 |
There was a problem hiding this comment.
Where did this URL come from? Accessing it shows "Domain for Sale".
| Dialog::alert('Title', 'Message', $buttons, fn ($selected) => { | ||
| echo "You selected {$buttons[$selected]}"; | ||
| }); | ||
| Dialog::alert('Title', 'Message'); |
There was a problem hiding this comment.
Have we dropped support for buttons on the alerts?
There was a problem hiding this comment.
@simonhamp and I are still discussing the best way vs the immediate way forward on this one.
| [start a new one](https://laravel.com/docs/installation). The most painless way to get PHP and Node up and running on your system is with | ||
| [Laravel Herd](https://herd.laravel.com). It's fast and free! | ||
|
|
||
| ## Private package |
There was a problem hiding this comment.
I think I will merge the Private package and Install NativePHP for mobile sections.
| After running: | ||
|
|
||
| ```bash | ||
| php artisan native:install |
There was a problem hiding this comment.
Since it references the command and we don't need to run it in this part of the documentation. I will use an inline code block instead of a full code block.
|
|
||
| Most of the system-related features are available through the `System` facade. | ||
|
|
||
| ## Synchronous vs. Asynchronous Methods |
There was a problem hiding this comment.
I'm not sure Synchronous vs. Asynchronous Methods belongs here. Maybe it should have its own page, even if it's a short one.
|
|
||
| _Coming Soon_ Options: `duration` and `intensity` | ||
|
|
||
| ## Push Notifications |
There was a problem hiding this comment.
Push notifications should have their own dedicated page, and should contain an installation and configuration guide for FCM and APN.
| 4. An active [Apple Developer account](https://developer.apple.com/) | ||
| 5. [A NativePHP for iOS license](https://checkout.anystack.sh/nativephp-ios) | ||
| 6. _Optional_ iOS device | ||
| 3. [A NativePHP for mobile license](https://checkout.anystack.sh/nativephp-ios) |
There was a problem hiding this comment.
Possible wrong link also as mentioned by Pete
| @@ -81,29 +83,6 @@ if ($token = System::getPushNotificationsToken()) { | |||
| Once you have the token, you may use it from your server-based applications to trigger Push Notifications directly to | |||
There was a problem hiding this comment.
This raised a couple of questions:
- Should these tokens be stored on the server?
- Could a user (on the server) have multiple tokens associated with it if they use multiple devices?
- How to handle tokens when a user logs out and logs back in on with a different account on the device?
Can you give a brief explainer on what's involved to handle messages server side?
|
Oh boy just a couple more days guys! This looking great already |
PeteBishwhip
left a comment
PeteBishwhip
left a comment
There was a problem hiding this comment.
I'm good with it as-is with one comment on use of Windows in a comment. But thats not a blocker in my opinion at all. Nice work Shane.
|
|
||
| #### For macOS | ||
| ```shell | ||
| export JAVA_HOME=$(/usr/libexec/java_home -v 17) // This isn't required if JAVA_HOME is already set in the Windows Env Variables |
There was a problem hiding this comment.
| export JAVA_HOME=$(/usr/libexec/java_home -v 17) // This isn't required if JAVA_HOME is already set in the Windows Env Variables | |
| export JAVA_HOME=$(/usr/libexec/java_home -v 17) // This isn't required if JAVA_HOME is already set in your system Environment Variables. |
I believe it's the same for Mac, so likely no need to reference Windows specifically. :)
simonhamp
left a comment
simonhamp
left a comment
There was a problem hiding this comment.
I made a few minor edits to clean some stuff up a bit, but otherwise this is looking great! Awesome work @shanerbaner82 🙌🏼
SHIP IT
6 participants
No description provided.