Skip to content

Update NationsGloryJava.yml#1

Open
baba33mrt wants to merge 2 commits intoNationsTools:mainfrom
baba33mrt:main
Open

Update NationsGloryJava.yml#1
baba33mrt wants to merge 2 commits intoNationsTools:mainfrom
baba33mrt:main

Conversation

@baba33mrt
Copy link
Member

@baba33mrt baba33mrt commented Jan 19, 2026

Type de modification

Coche au moins une case

  • Ajout de pattern
  • Correction de pattern existant
  • Amélioration / clarification
  • Autre (à préciser)

Description

Explique clairement :

  • le ou les logs concernés
    Ajout des logs suivantes :
    • Actions / enchères
      • New
      • Bid
      • End
      • Refund
      • Cancelled
    • ChestShop
      • Transaction
    • AdminShop
      • Transactions
      • Catalog
    • Wars
      • Add
      • start
      • surrender
      • status change
      • won
      • warzone add
    • Economy & countries
      • country buy
      • country action buy
      • country found
      • country new leader
      • colony request
    • Powerboost
      • PowerBoost player
      • PowerBoost country
    • Meteor
      • spawn
    • Access P
      • Set
      • Remove
    • Divers
      • duel win
      • restricted item
      • missile launch
    • Session
      • Déconnexion

Ajouts basé sur le script python d'akael V.2023 , des modifications de logs ont du avoir lieu je vous laisses me le faire remonter


Impact potentiel

  • Aucun impact sur les patterns existants
  • Impact rétro-compatible
  • Risque de rupture de compatibilité (à justifier)

Justification (si nécessaire) : /

Checklist

  • Le fichier YAML est valide
  • Aucune clé dupliquée
  • Le pattern est dans la bonne catégorie
  • Le nom du pattern est explicite et en snake_case
  • Les variables utilisées sont cohérentes et explicites
  • La modification est justifiée (si pattern existant)

Informations complémentaires

Toute information utile à la revue : Ajouts basé sur le script python d'akael V.2023 , des modifications de logs ont du avoir lieu je vous laisses me le faire remonter

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70b6c3be72

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# ChestShop
# ===========================
chestshop_transaction:
pattern: "{timestamp} [ChestShop] {player} {action} {qty} {item} for {price} {direction} {target} at [world] {x}, {y}, {z}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Capture ChestShop world name instead of literal

This pattern hard-codes at [world], so it only matches transactions that occur in a world literally named “world”. ChestShop logs include the world name in brackets (e.g., at [world_nether] …), and those entries will not parse with this pattern, causing missed transactions whenever servers use non-default world names. Consider capturing the world token (e.g., [{world}]) so multi-world logs still match.

Useful? React with 👍 / 👎.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds 30 new log patterns to the NationsGloryJava.yml file for parsing additional server logs from the NationsGlory Minecraft server plugin. The patterns are based on a Python script from akael V.2023 and cover various game mechanics including auctions, shops, wars, economy, and player sessions.

Changes:

  • Added patterns for auction system events (new, bid, end, refund, cancelled)
  • Added patterns for shop transactions (ChestShop, AdminShop, Catalog)
  • Added patterns for war-related events (add, start, surrender, status changes, warzone)
  • Added patterns for economy and country management (purchases, founding, leadership changes, colonies)
  • Added patterns for miscellaneous events (powerboosts, meteors, access control, duels, missiles, player sessions)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +182 to +194
pattern: "{timestamp} [Auction] New Player auction {details}"

auction_bid:
pattern: "{timestamp} [Auction] New Player bid {details}"

auction_end:
pattern: "{timestamp} [Auction] End of auction {details}"

auction_refund:
pattern: "{timestamp} [Auction] Refund {details}"

auction_cancelled:
pattern: "{timestamp} [Auction] CANCELLED {details}"
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider providing more specific variable names instead of the generic {details} placeholder. Other patterns in the file use explicit variables (e.g., {player}, {country}, {amount}) which makes log parsing more structured and useful. For example, this could be parsed into specific fields like {auction_id}, {item}, {price}, {player}, etc.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Les enchères n'existe plus, plus aucune log sur ce système


# ===========================
# ChestShop
# ===========================
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern variable {direction} is ambiguous. Consider using a more descriptive name like {transaction_type} or clarifying in documentation what values this field represents (e.g., "to"/"from", "bought"/"sold", etc.).

Suggested change
# ===========================
# ===========================
# {direction}: direction of the transaction, e.g. "to"/"from" the target player or shop.

Copilot uses AI. Check for mistakes.
Comment on lines +208 to +212
adminshop_transaction:
pattern: "{timestamp} {player} {details} from Adminshop"

adminshop_transaction_lower:
pattern: "{timestamp} {player} {details} from adminshop"
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent capitalization between patterns. Line 209 uses "Adminshop" while line 212 uses "adminshop" in the pattern text. If these represent the same log source, they should use consistent capitalization. If they represent different log formats from the server, consider using more distinct pattern names to clarify the difference.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update depuis le catalogue :
{timestamp} [INFO] [NationsGUI] [Catalog] Player {player} bought the item {id} {quantity} for {price}$ (including delivery {tax}$) to player Bank:

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pattern: "{timestamp} {player} {details} from adminshop"

catalog_transaction:
pattern: "{timestamp} [Catalog] {details}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Même chose que pour l'adminshop puisque tout est catalogue :
{timestamp} [INFO] [NationsGUI] [Catalog] Player {player} bought the item {id} {quantity} for {price}$ (including delivery {tax}$) to player Bank:

# War / Warzone
# ===========================
war_add:
pattern: "{timestamp} Add war {details}"
Copy link
Contributor

@AirrOne AirrOne Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update :
{timestamp} [INFO] [NationsUtils] Add war event {war_reason} between {country_a} and {country_b}

pattern: "{timestamp} Add war {details}"

war_start:
pattern: "{timestamp} START WAR {details}"
Copy link
Contributor

@AirrOne AirrOne Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détails :
{timestamp} [INFO] [NationsGUI] START WAR between {country_a} and {country_b} for reason {reason}

pattern: "{timestamp} START WAR {details}"

war_surrender:
pattern: "{timestamp} SURREND WAR {details}"
Copy link
Contributor

@AirrOne AirrOne Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détails :
{timestamp} [INFO] [NationsGUI] {country_a} SURREND WAR AGAINST {country_b} APPLY REWARDS : {reward_type}#{amount}

pattern: "{timestamp} SURREND WAR {details}"

war_status_change:
pattern: "{timestamp} Change status of war request between {country_a} and {country_b} to {status}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update :
{timestamp} Change status of war request between {country_a} and {country_b} by {player} to {status}

pattern: "{timestamp} Change status of war request between {country_a} and {country_b} to {status}"

war_won:
pattern: "{timestamp} War won {details}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détails :
{timestamp} [INFO] [NationsUtils] War won by {country_a} against {country_b}

pattern: "{timestamp} War won {details}"

warzone_add:
pattern: "{timestamp} [WarZone] Add {details}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 formes différentes :
{timestamp} [INFO] [WarZone] Add 0.25 skill multiplier to {country}
{timestamp} [INFO] [WarZone] Add 1.0 power to {country}
{timestamp} [INFO] [WarZone] Le pays {country} vient de recevoir un powerboost de 1.0 de la warzone.

# Economie / Pays
# ===========================
country_buy:
pattern: "{timestamp} ACHAT PAYS {details}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détails :
{timestamp} [INFO] ACHAT PAYS {country} PAR {pseudo} POUR {amount}$

pattern: "{timestamp} ACHAT PAYS {details}"

country_action_buy:
pattern: "{timestamp} ACHAT ACTION : {details}"
Copy link
Contributor

@AirrOne AirrOne Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détails :
{timetamp} [INFO] [NationsGUI] ACHAT ACTION : {country_a} ({player}) buy action of {country_b }for {price}$

pattern: "{timestamp} {player} est le nouveau dirigeant du pays {country}"

colony_request:
pattern: "{timestamp} {player} vient de faire une demande de colonie sur {country}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update :
N'existe plus, car les colonies ont disparues

pattern: "{timestamp} POWERBOOST DE {player} {details}"

powerboost_country:
pattern: "{timestamp} Powerboost to {country} {details}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détails :
Je n'ai trouvé aucune logs concernant les powerboost joueur/pays hors warzone

# Meteore
# ===========================
meteor_spawn:
pattern: "{timestamp} METEOR SPAWNED IN {details}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détails :
{timestamp} [INFO] METEOR SPAWNED IN {planet} on player {player} at {x}, {y}, {z}

# Access / Permissions
# ===========================
access_set:
pattern: "{timestamp} {player} set access to player {target} {details}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détails :
{timestamp} [INFO] [Factions] Player {player} set access to player {player} in chunk {x}, {z} to true

pattern: "{timestamp} {player} set access to player {target} {details}"

access_remove:
pattern: "{timestamp} {player} remove access to player {target} {details}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détails :
{timestamp} [INFO] [Factions] Player {player} remove access to player {player} in chunk {x}, {z} to false

# Divers
# ===========================
duel_win:
pattern: "{timestamp} AFTER WIN DUEL {details}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update :
Les logs duel ne sont plus qu'au lancement et non à la fin
{timestamp} [INFO] START DUEL {player_a} vs {player_b} BET {amount}

pattern: "{timestamp} AFTER WIN DUEL {details}"

restricted_item_interaction:
pattern: "{timestamp} {player} interacts with restricted item {details}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détails :
{timestamp} [INFO] [NationsUtils] Player {player} interacts with restricted item {id}

# Player session
# ===========================
player_left:
pattern: "{timestamp} [INFO] {player} left the game."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Détails :
deconnection : "{timestamp} [INFO] §7[*banner id="minus"]§7 {player} ({number}/300)

Copy link
Contributor

@AirrOne AirrOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques logs nécessite une mise à jour et certaines ne sont plus existantes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants