This repository was archived by the owner on May 8, 2023. It is now read-only.
Added support for single quotes in css. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @NathanWalker , any reason for not merging this PR ? |
|
looks like he has given up on this lib |
Owner
|
@devlinpadayachee hi - if this fixes a current issue for you just ping back and perhaps we can bring this lib under scope so it’s more visible and tended to. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20.
Currently, the plugin doesn't support single quotes on CSS. This means that this doesn't work:
This PR changes the
cleanValueregex to support both"and'.I added/changed tests and changed the demo app, so I know it works.
Thanks!
PS: The real reason why I made this PR is because I couldn't get prettier/eslint/vscode to stop converting
"to'in my CSS file 😎...