Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Rust-side test dataset creation to consistently use dataset::samples::ZarrTestBuilder, replacing older ad-hoc Zarr construction helpers and updating dependent tests to the new APIs (including an explicit band dimension).
Changes:
- Updated
ZarrTestBuilderto model 3D arrays(band, y, x)and expanded helper constructors accordingly. - Migrated multiple tests to use
ZarrTestBuilder/ newsamples::*_zarr(...)helpers instead of the removed legacy builders. - Adjusted dataset and lazy-subset tests to use 3D
ArraySubsetranges and validate 3D shapes.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/revrt/src/routing/features/samples.rs | Updates sample docs to reference the new random multi-variable helper. |
| crates/revrt/src/lib.rs | Migrates routing tests to the new samples helpers and builder-based dataset creation. |
| crates/revrt/src/dataset/samples.rs | Extends ZarrTestBuilder to include band dimension + new helpers; removes legacy builders. |
| crates/revrt/src/dataset/mod.rs | Updates dataset tests to use builder-based Zarr fixtures and new helper signatures. |
| crates/revrt/src/dataset/lazy_subset.rs | Updates async lazy-subset tests for 3D (band, y, x) subsets and shapes. |
| crates/revrt/src/cost.rs | Updates cost tests to build Zarr fixtures via ZarrTestBuilder. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 25 25
Lines 2765 2765
Branches 320 320
=======================================
Hits 2747 2747
Misses 9 9
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
castelao
previously approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved all the tests I could find that were creating a Zarr file for testing to use
ZarrTestBuilder. Deprecated the old functions and approach in favor of this cleaner setup. Thanks @castelao!!