Merged
Conversation
Help to distinguish between the variable 'cost' and the swap dataset formerly also called 'cost'.
castelao
added
enhancement
Instead of assuming that cost chunk shape is equal to all source variables' chunks, we now request input features with ArraySubset.
Those will be removed, but for now let's just silence the warning.
It should be considered an error to request a features variable that doesn't exist or a subset outside the domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate away from
LazyChunktoLazySubsetso we avoid assumptions on the chunk's shapes from input features as well as output costs.Spin off from #96, which was getting too large and covering multiple scopes.
This is a requirement to allow a cost with a chunk shape different than the input features. It also do not impose that input features dataset to have one single chunk grid between all variables.