Skip to content

Fix broad except ValueError in degradation_timeseries_plot for multi-YoY detection #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdeline merged 2 commits into from
Mar 6, 2026
Merged

Fix broad except ValueError in degradation_timeseries_plot for multi-YoY detection #490

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
425c92d
Initial plan
Copilot Mar 5, 2026
ceb41f1
Replace broad except ValueError with explicit duplicate-index check i…
Copilot Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions rdtools/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,8 @@ def _bootstrap(x, percentile, reps):
if ci_color is None:
ci_color = 'C0'

try:
roller = results_values.rolling(f'{rolling_days}d', min_periods=rolling_days//4,
center=True)
except ValueError:
results_values = results_values.sort_index()
if results_values.index.has_duplicates:
# this occurs with degradation_year_on_year(multi_yoy=True). resample to daily mean
warnings.warn(
"Input `yoy_info['YoY_values']` appears to have multiple annual "
Expand All @@ -503,6 +501,9 @@ def _bootstrap(x, percentile, reps):
roller = results_values.resample('D').mean().rolling(f'{rolling_days}d',
min_periods=rolling_days//4,
center=True)
else:
roller = results_values.rolling(f'{rolling_days}d', min_periods=rolling_days//4,
center=True)
# unfortunately it seems that you can't return multiple values in the rolling.apply() kernel.
# TODO: figure out some workaround to return both percentiles in a single pass
if include_ci:
Expand Down