Skip to content

fix: resolve reeds translation issues and update to latest code base#266

Open
mcllerena wants to merge 5 commits into
mainfrom
ml/update-r2s
Open

fix: resolve reeds translation issues and update to latest code base#266
mcllerena wants to merge 5 commits into
mainfrom
ml/update-r2s

Conversation

@mcllerena

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 2, 2026 02:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ReEDS→Sienna translation to carry more operational metadata into the target Sienna system (generator services, initial dispatch, non-zero operating costs) and adds a post-processing step to translate ReEDS emissions supplemental attributes into Sienna emissions attributes.

Changes:

  • Add post-translation processing to attach EmissionsData to translated thermal generators.
  • Enhance thermal generator translation to include reserve participation (services) and non-zero operation cost inputs.
  • Update translation rules so thermal generators depend on translated reserves and use new getters for services and active_power.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/translation.py Calls new post-processing hook to add generator emissions after rule application.
packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/getters.py Builds thermal operation cost from component attributes; adds getters for thermal services and initial active power.
packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/getter_utils.py New utility to translate ReEDS emissions supplemental attributes into Sienna EmissionsData.
packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/config/rules.json Wires new thermal getters and adds dependency on variable_reserve.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/getter_utils.py Outdated
Comment thread packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/translation.py
@mcllerena mcllerena requested a review from pesap June 2, 2026 03:09

@pesap pesap left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. The new emissions post-processing path currently blocks basic ReEDS-to-Sienna translation because EmissionsData cannot be imported from r2x_sienna.models.attributes. Once that model/import path is corrected, please rerun the pre-push/quick pytest hook; CI currently stops at this first failure.

Comment thread packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/getter_utils.py Outdated
mcllerena and others added 2 commits June 2, 2026 21:31
Signed-off-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.87%. Comparing base (649eba0) to head (2842a51).

Files with missing lines Patch % Lines
...-to-sienna/src/r2x_reeds_to_sienna/getter_utils.py 81.63% 9 Missing ⚠️
...reeds-to-sienna/src/r2x_reeds_to_sienna/getters.py 83.33% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   84.95%   84.87%   -0.09%     
==========================================
  Files          19       20       +1     
  Lines        4561     4614      +53     
==========================================
+ Hits         3875     3916      +41     
- Misses        686      698      +12     
Files with missing lines Coverage Δ
...s-to-sienna/src/r2x_reeds_to_sienna/translation.py 100.00% <100.00%> (ø)
...reeds-to-sienna/src/r2x_reeds_to_sienna/getters.py 87.97% <83.33%> (-0.29%) ⬇️
...-to-sienna/src/r2x_reeds_to_sienna/getter_utils.py 81.63% <81.63%> (ø)

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcllerena mcllerena requested a review from pesap June 3, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants