fix: resolve reeds translation issues and update to latest code base#266
fix: resolve reeds translation issues and update to latest code base#266mcllerena wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ReEDS→Sienna translation to carry more operational metadata into the target Sienna system (generator services, initial dispatch, non-zero operating costs) and adds a post-processing step to translate ReEDS emissions supplemental attributes into Sienna emissions attributes.
Changes:
- Add post-translation processing to attach
EmissionsDatato translated thermal generators. - Enhance thermal generator translation to include reserve participation (
services) and non-zero operation cost inputs. - Update translation rules so thermal generators depend on translated reserves and use new getters for
servicesandactive_power.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/translation.py | Calls new post-processing hook to add generator emissions after rule application. |
| packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/getters.py | Builds thermal operation cost from component attributes; adds getters for thermal services and initial active power. |
| packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/getter_utils.py | New utility to translate ReEDS emissions supplemental attributes into Sienna EmissionsData. |
| packages/r2x-reeds-to-sienna/src/r2x_reeds_to_sienna/config/rules.json | Wires new thermal getters and adds dependency on variable_reserve. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pesap
left a comment
There was a problem hiding this comment.
Thanks for the update. The new emissions post-processing path currently blocks basic ReEDS-to-Sienna translation because EmissionsData cannot be imported from r2x_sienna.models.attributes. Once that model/import path is corrected, please rerun the pre-push/quick pytest hook; CI currently stops at this first failure.
Signed-off-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
- Coverage 84.95% 84.87% -0.09%
==========================================
Files 19 20 +1
Lines 4561 4614 +53
==========================================
+ Hits 3875 3916 +41
- Misses 686 698 +12
🚀 New features to boost your workflow:
|
No description provided.