feat: add new types of loads for reeds to plexos translations

[mcllerena]

No description provided.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds support for translating new ReEDS demand component types (electrolyzer + data center) into PLEXOS Purchasers, including purchaser/node memberships and time series transfer.

Changes:

• Add rules mapping ReEDSElectrolyzerDemand and ReEDSDataCenterDemand to PLEXOSPurchaser and add purchaser→node membership creation.
• Add purchaser time series transfer step to the ReEDS→PLEXOS translation flow.
• Update tests to cover rule presence and translation behavior for the new demand types.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
pyproject.toml	Adds new dependencies and switches several uv sources to editable path-based deps.
packages/r2x-reeds-to-plexos/tests/test_translation_rule_application.py	Adds end-to-end translation assertions for electrolyzer/data-center demands.
packages/r2x-reeds-to-plexos/tests/test_rule_loading.py	Adds tests ensuring new mapping rules exist in rules.json.
packages/r2x-reeds-to-plexos/tests/test_getters_utils.py	Adds unit test for attaching time series to purchasers.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/translation.py	Runs purchaser time-series attachment during translation.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/getters_utils.py	Implements attach_time_series_to_purchasers.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/getters.py	Expands lookup to include new demand components for memberships.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/config/rules.json	Adds new purchaser rules + purchaser node membership; adjusts consuming-tech rule filtering.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/config/defaults.json	Adds an electrolyzer defaults block.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/init.py	Exports attach_time_series_to_purchasers.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 87.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.99%. Comparing base (649eba0) to head (7f49f37).

Files with missing lines	Patch %	Lines
...to-plexos/src/r2x_reeds_to_plexos/getters_utils.py	89.18%	4 Missing ⚠️
...reeds-to-plexos/src/r2x_reeds_to_plexos/getters.py	76.92%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   84.95%   84.99%   +0.03%     
==========================================
  Files          19       19              
  Lines        4561     4584      +23     
==========================================
+ Hits         3875     3896      +21     
- Misses        686      688       +2     

Files with missing lines	Coverage Δ
...-to-sienna/src/r2x_plexos_to_sienna/translation.py	100.00% <100.00%> (ø)
...eeds-to-plexos/src/r2x_reeds_to_plexos/__init__.py	100.00% <ø> (ø)
...s-to-plexos/src/r2x_reeds_to_plexos/translation.py	100.00% <100.00%> (ø)
...s-to-sienna/src/r2x_reeds_to_sienna/translation.py	100.00% <100.00%> (ø)
...enna-to-plexos/src/r2x_sienna_to_plexos/getters.py	81.96% <100.00%> (-0.02%)	⬇️
...-to-plexos/src/r2x_sienna_to_plexos/translation.py	100.00% <100.00%> (ø)
...reeds-to-plexos/src/r2x_reeds_to_plexos/getters.py	83.05% <76.92%> (+0.47%)	⬆️
...to-plexos/src/r2x_reeds_to_plexos/getters_utils.py	92.63% <89.18%> (-1.57%)	⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pesap]

Requesting changes for the dependency contract issue noted inline.

[pesap]

One blocker: the package metadata still allows dependency versions that do not provide the new model classes used by these rules.

Evidence:

• packages/r2x-reeds-to-plexos/pyproject.toml allows r2x-reeds>=0.4.0,<1.0.0 and r2x-plexos>=0.1.4,<1.0.0.
• The new rules reference ReEDSElectrolyzerDemand, ReEDSDataCenterDemand, and PLEXOSPurchaser.
• r2x-reeds==0.4.0 does not expose the new ReEDS demand classes, and r2x-plexos==0.1.4 does not expose PLEXOSPurchaser.

Can you either bump the minimum dependency versions to released versions that contain those classes, or make the new rules conditional on class availability? Otherwise valid installs under the declared package contract can fail the new translation path.

[pesap]

This assertion appears to encode test-order dependence. get_node_number("p123") earlier in the module reserves 123 in global state, so NODE_123 becomes 1230 only because a previous test ran first. Please reset the global numbering state between tests or move numbering state into the translation context, then keep NODE_123 deterministic.