Skip to content

Refrigeration Output Variables#458

Open
mdahlhausen wants to merge 12 commits intomainfrom
refrigeration_output_vars
Open

Refrigeration Output Variables#458
mdahlhausen wants to merge 12 commits intomainfrom
refrigeration_output_vars

Conversation

@mdahlhausen
Copy link
Copy Markdown
Contributor

@mdahlhausen mdahlhausen commented Apr 9, 2026

Pull request overview

This PR includes additional output variables for refrigeration equipment defrost

  • adds low and medium temperature case and walk-in defrost energy variables and counts
  • adds these to the end use plotting charts

Pull Request Author

  • Reporting Measures
  • Postprocessing

Pull Request Author Checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added or edited tests for measures that adequately cover anticipated cases (should add grocery store to comstock_sensitivity_reports measure. Added in testing, removed for this PR, can add back if desired).
  • New or changed register values reflected in comstock_column_definitions.csv
  • Updated measure .xml(s)
  • Ran 10k+ test run and checked failure rate to make sure no new errors were introduced
  • ComStock documentation written or updated (refrigeration defrost detail needed)
  • Change document written and assigned to a reviewer (did not write one, as this is just postprocessing changes, but there is a openstudio-standards update that could be included)
  • All new / modified functions have docstrings (two new methods need docstrings)

Pull Request Reviewer Checklist:

  • Perform a code review on GitHub
  • Author had ensured all modified and new functions have docstrings
  • All changes have been implemented: data, methods, tests, documentation
  • Ensured code files contain License reference
  • Check edited measure .xml files updated
  • ComStock documentation adequately describes the new assumptions
  • Reviewed change documentation, results differences are reasonable, and no new errors introduced
  • Author has addressed comments in change documentation

@mdahlhausen mdahlhausen added reporting measure PR improves or adds reporting measures postprocessing PR improves or adds postprocessing content labels Apr 9, 2026
use 0.8.6 until next update; cd105f8e8f5d0980b5d0bb2468ec89c9aa517f04 contains changes to low temp walk-in defrost assumptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

postprocessing PR improves or adds postprocessing content reporting measure PR improves or adds reporting measures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant