Skip to content

Robustify post process#138

Merged
malihass merged 17 commits intomainfrom
missingdgas
Oct 2, 2025
Merged

Robustify post process#138
malihass merged 17 commits intomainfrom
missingdgas

Conversation

@malihass
Copy link
Collaborator

@malihass malihass commented Oct 1, 2025

  • Some fields where expected for instantaneous kla calculation and were not always there. We now force these fields to be present in the tutorial and experimental cases
  • d.gas is not present if we run a constant bubble size diameter case. If it is absent, we read d.gas from phaseProperties.
  • If thermo:mu.liquid is not present, we check that we are using a constant viscosity model and read the muMixLiq from globalVars
  • Computation of kla did not handle passing the species as str while it should be allowed. If passed as string, species are internally converted to list of 1 species.
  • Compute KLA with the fitting method : separate kla calculation from the file reading so that the same function can be used for the tutorial and post_quantities. Change the logging to show the units.
  • Read species molecular weight from the thermophysical properties first rather than globalVars. Global vars is the last resort. Add a test for this workflow

@malihass malihass marked this pull request as draft October 1, 2025 23:18
@malihass malihass marked this pull request as ready for review October 2, 2025 17:18
@malihass malihass merged commit 0fe313d into main Oct 2, 2025
11 checks passed
@malihass malihass deleted the missingdgas branch October 2, 2025 19:28
github-actions bot pushed a commit that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants