fix(tests): remove unused pytest imports and fix stale comments#9
Merged
Conversation
- Drop unused `import pytest` from test_resolver.py and test_shaker.py - Replace `type(x) is type(y)` with `isinstance` in test_shaker.py make_pool helper - Rewrite implementation-detail comments in test_packer.py to describe behavior instead - Fix two factually wrong range-literal comments in test_upstream_patches.py Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 6 6
Lines 244 244
Branches 53 53
=======================================
Hits 243 243
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import pytestfromtest_resolver.pyandtest_shaker.pytype(x) is type(y)withisinstanceintest_shaker.pymake_poolhelper (Copilot Autofix suggestion)test_packer.pyto describe observable behavior instead of internal branch numbers and parameter namestest_upstream_patches.py([0:5]→[0:1], and swapped step/end in the negative-step description)Test plan
uv run pytest— all 83 tests pass, no new failures🤖 Generated with Claude Code