Potential fix for 1 code quality finding#14
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 6 6
Lines 244 244
Branches 53 53
=======================================
Hits 243 243
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tbjers
added a commit
that referenced
this pull request
Jun 7, 2026
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
tbjers
added a commit
that referenced
this pull request
Jun 7, 2026
* Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Fix corrupted test_shaker.py from bad Copilot Autofix patches Remove duplicate `def parse` header that caused an IndentationError (breaking all 23 tests), duplicate `from typing import Any` import, and duplicate `assert "cube" in names` assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Potential fixes for 2 code quality findings (#13) * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Fix corrupted test_shaker.py from bad Copilot Autofix patches Remove duplicate `def parse` header that caused an IndentationError (breaking all 23 tests), duplicate `from typing import Any` import, and duplicate `assert "cube" in names` assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix (#14) Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Fix docstring module reference and redundant assertion in test_shaker.py Correct _add_to_pool module reference from openscad_packer.shaker to openscad_packer.packer, remove the redundant assert that was fully subsumed by the equality check, and clarify why the result is empty. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
tbjers
added a commit
that referenced
this pull request
Jun 7, 2026
* Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Fix corrupted test_shaker.py from bad Copilot Autofix patches Remove duplicate `def parse` header that caused an IndentationError (breaking all 23 tests), duplicate `from typing import Any` import, and duplicate `assert "cube" in names` assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Potential fixes for 2 code quality findings (#13) * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Fix corrupted test_shaker.py from bad Copilot Autofix patches Remove duplicate `def parse` header that caused an IndentationError (breaking all 23 tests), duplicate `from typing import Any` import, and duplicate `assert "cube" in names` assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix (#14) Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Fix docstring module reference and redundant assertion in test_shaker.py Correct _add_to_pool module reference from openscad_packer.shaker to openscad_packer.packer, remove the redundant assert that was fully subsumed by the equality check, and clarify why the result is empty. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Potential fixes for 2 code quality findings (#13) * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Fix corrupted test_shaker.py from bad Copilot Autofix patches Remove duplicate `def parse` header that caused an IndentationError (breaking all 23 tests), duplicate `from typing import Any` import, and duplicate `assert "cube" in names` assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Fix corrupted test_shaker.py from bad Copilot Autofix patches Remove duplicate `def parse` header that caused an IndentationError (breaking all 23 tests), duplicate `from typing import Any` import, and duplicate `assert "cube" in names` assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Potential fixes for 2 code quality findings (#13) * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Fix corrupted test_shaker.py from bad Copilot Autofix patches Remove duplicate `def parse` header that caused an IndentationError (breaking all 23 tests), duplicate `from typing import Any` import, and duplicate `assert "cube" in names` assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * Potential fixes for 2 code quality findings (#13) * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Fix corrupted test_shaker.py from bad Copilot Autofix patches Remove duplicate `def parse` header that caused an IndentationError (breaking all 23 tests), duplicate `from typing import Any` import, and duplicate `assert "cube" in names` assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * Apply suggested fix to tests/test_shaker.py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies 1/3 suggestions from code quality AI findings. 2 suggestions were skipped to avoid creating conflicts.