Skip to content

Potential fixes for 2 code quality findings #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbjers merged 2 commits into from
Jun 6, 2026
Merged

Potential fixes for 2 code quality findings #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d557808
Apply suggested fix to tests/test_upstream_patches.py from Copilot Au…
tbjers Jun 6, 2026
0fa35ae
Apply suggested fix to tests/test_upstream_patches.py from Copilot Au…
tbjers Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/test_upstream_patches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def parse_and_print(path: Path, src: str) -> str:
"""Write *src* to *path*, parse it, and pretty-print back to string."""
path.write_text(src, encoding="utf-8")
nodes = getASTfromFile(str(path), process_includes=False) or []
return to_openscad(nodes)
return to_openscad(nodes) or ""


def pack(entry: Path, library_paths: list[str] | None = None) -> str:
Expand Down Expand Up @@ -127,8 +127,9 @@ def test_three_arg_range_explicit_step_preserved(self, tmp_path):
assert "[0:1:2]" in out

def test_three_arg_range_large_step_preserved(self, tmp_path):
# [0:5:1] means start=0, step=5, end=1 — semantically different from [0:1]
# ([0:5] is a two-arg range: start=0, end=5, implicit step=1.)
# [0:5:1] is a three-arg range [start:step:end] => start=0, step=5, end=1.
# This is semantically different from two-arg [0:1] ([start:end], implicit step=1).
# Likewise, [0:5] is also two-arg and must not replace [0:5:1].
src = "x = [for (i=[0:5:1]) i];"
out = parse_and_print(tmp_path / "t.scad", src)
assert "[0:5:1]" in out
Expand Down
Loading