Add support for windows generated trx#268
Open
remoteexception wants to merge 2 commits intoNasAmin:mainfrom
Open
Add support for windows generated trx#268remoteexception wants to merge 2 commits intoNasAmin:mainfrom
remoteexception wants to merge 2 commits intoNasAmin:mainfrom
Conversation
…nerated-trx Add support for windows generated trx
NasAmin
requested changes
Jan 22, 2023
Owner
NasAmin
left a comment
NasAmin
left a comment
There was a problem hiding this comment.
Thanks for opening a PR to make this action better and apologies for the delay.
Comment on lines
-17
to
+19
| run: npm ci | ||
| run: | | ||
| # todo: resolve npm dependency conflicts and than remove the --legacy-peer-deps option | ||
| npm ci --legacy-peer-deps |
Owner
There was a problem hiding this comment.
I have fixed the peer deps, can you please rebase from main and revert this change?
| <ResultSummary outcome="Completed"> | ||
| <Counters total="1" executed="1" passed="1" failed="0" error="0" timeout="0" aborted="0" inconclusive="0" passedButRunAborted="0" notRunnable="0" notExecuted="0" disconnected="0" warning="0" completed="0" inProgress="0" pending="0" /> | ||
| </ResultSummary> | ||
| </TestRun> No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.