Conversation
ProgramPhoenix
previously approved these changes
Jan 5, 2026
Member
|
I also added fixes for two Problems in the backend. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a reusable TimedConfirmationButton component that requires two clicks within a configurable time period to confirm destructive actions. The component replaces browser-native confirm() dialogs for item and inventory deletion operations, providing a more modern and consistent user experience.
Key changes:
- New
TimedConfirmationButton.vuecomponent with countdown timer functionality - Updated deletion UI in
ItemRowDisplayandInventoryContainerto use the new confirmation button - Backend bug fixes: corrected inventory deletion permission check and prevented DM users from being added as readers/writers of their own inventories
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
frontend/src/components/TimedConfirmationButton.vue |
New component implementing timed two-click confirmation with countdown display |
frontend/src/components/ItemRowDisplay.vue |
Replaces standard delete button with TimedConfirmationButton for item deletion |
frontend/src/components/InventoryContainer.vue |
Replaces browser confirm() dialog with TimedConfirmationButton for inventory deletion |
backend/inventarwerk_api/src/routers/inventory_router.rs |
Fixes deletion permission logic and prevents self-assignment of DM permissions during inventory creation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ProgramPhoenix
previously approved these changes
Jan 5, 2026
ProgramPhoenix
previously approved these changes
Jan 5, 2026
ProgramPhoenix
previously approved these changes
Jan 11, 2026
Kr0nox
requested changes
Jan 17, 2026
Kr0nox
requested changes
Jan 18, 2026
ProgramPhoenix
force-pushed
the
deletion-confirmation
branch
from
2f5ed33 to
d563728
Compare
Kr0nox
previously approved these changes
Feb 13, 2026
Kr0nox
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a timed confirmation button, which needs to be pressed twice within a definable period of time to actually trigger.
Uses this button for deletion buttons of items and inventories. Fixes #200