Open
Conversation
Notes - Only singles supported - Unstable for other replays - user cannot choose their own replay to watch
Owner
|
@Mimerme hey tks for the PR. Im in the middle of something; I'll take a look as soon as I can |
…r implementation.
…l Gift, Fling. Some refactoring.
…oon, Expert Belt, Float Stone, Light Metal Heavy Metal, Safety Goggles, Deap Sea *, Light Ball, Soul Dew, time-space-orbs, Life Orb, Leftovers. Also typing fixes.
|
it's really hard reviewing this since it seems like you didnt merge upstream/master correctly. I can see commis made by me while it shouldnt happen |
- changed some variable names
Author
|
@tetonn New to contributing code with git, so what does it exactly mean that I didn't merge the branches correctly? What should it be instead? |
|
Like usually you want to:
So on a pull request it shows your commits only and something like Merge remote-tracking branch 'upstream/master' into xxx. Not sure what Nam thinks about it though |
Owner
|
Yeah that sounds good |
Author
|
Ah ok, thank you for the help TeToNN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO : Allow user to view their own replays
Create a better front end
Download and watch local replays
Make code prettier?
Any criticism would be greatly appreciated, thanks!