Fix overlay edge position restore#852
Open
vibhor1102 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #851.
This PR fixes overlay menu position restore for valid edge coordinates. A saved position with
x = 0,y = 0, or both should mean "the user placed the overlay on the screen edge", not "there is no saved position".Root Cause
SharedPreferences.getInt(..., 0)used0both as the missing-value fallback and as a valid coordinate. The restore code then treated0as invalid, so edge placements could fall back to first-run centering.Changes
SharedPreferences.contains(...)to distinguish missing keys from saved zero coordinates.(0, y),(x, 0),(0, 0), and missing preferences.Validation
./gradlew.bat --no-daemon --max-workers=3 --console=plain :core:common:overlays:testFDroidDebugUnitTest