wip(<General Control Module>):#174
Open
cameronbedard wants to merge 6 commits intoNYU-Processor-Design:mainfrom
Open
wip(<General Control Module>):#174cameronbedard wants to merge 6 commits intoNYU-Processor-Design:mainfrom
cameronbedard wants to merge 6 commits intoNYU-Processor-Design:mainfrom
Conversation
implemented the documentation, needs to be reviewed [skip ci]
Collaborator
|
Please put wip in the PR title itself |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 91.15% 88.23% -2.93%
==========================================
Files 15 1 -14
Lines 294 17 -277
Branches 0 4 +4
==========================================
- Hits 268 15 -253
+ Misses 26 1 -25
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worked on the general control module throughout the semester. Here is the pull request.