Incomplete Testbench#23
Open
dpcarry wants to merge 2 commits intoNYU-Processor-Design:mainfrom
Open
Conversation
rishyak
reviewed
Feb 21, 2024
|
|
||
| TEST_CASE("SimpleDecoder, Basic Functionality") { | ||
| VSimpleDecoder_tl* decoder = new VSimpleDecoder_tl; | ||
| Verilated::traceEverOn(true); |
Member
There was a problem hiding this comment.
Unnecessary, if you want waveforms, add TRACE_FST in nyu_target_verilate()
rishyak
reviewed
Feb 21, 2024
| TEST_CASE("SimpleDecoder, Dummy Test") {} | ||
|
|
||
| TEST_CASE("SimpleDecoder, Basic Functionality") { | ||
| VSimpleDecoder_tl* decoder = new VSimpleDecoder_tl; |
rishyak
reviewed
Feb 21, 2024
Comment on lines
+8
to
+18
| decoder->clk = 0; | ||
| decoder->nReset = 1; | ||
| decoder->eval(); | ||
| decoder->clk = 1; | ||
| decoder->eval(); | ||
| decoder->clk = 0; | ||
| decoder->eval(); | ||
| decoder->nReset = 0; | ||
| decoder->eval(); | ||
| decoder->clk = 1; | ||
| decoder->eval(); |
Member
There was a problem hiding this comment.
nyu-util offers basic utilities like reset and tick. Should be replaced with nyu::reset(decoder)
Member
There was a problem hiding this comment.
You also miss the test for 0 where the selector will return 0.
rishyak
reviewed
Feb 21, 2024
Comment on lines
+25
to
+29
| decoder->eval(); | ||
| decoder->clk = 0; //falling edge | ||
| decoder->eval(); | ||
| decoder->clk = 1; //rising edge | ||
| decoder->eval(); |
Member
There was a problem hiding this comment.
replace with nyu::tick(decoder)
rishyak
reviewed
Feb 21, 2024
| decoder->clk = 1; //rising edge | ||
| decoder->eval(); | ||
|
|
||
| CAPTURE(address, expected_sel); //capture the values |
Member
There was a problem hiding this comment.
Why are you CAPTUREing the values?
rishyak
reviewed
Feb 21, 2024
Comment on lines
+8
to
+18
| decoder->clk = 0; | ||
| decoder->nReset = 1; | ||
| decoder->eval(); | ||
| decoder->clk = 1; | ||
| decoder->eval(); | ||
| decoder->clk = 0; | ||
| decoder->eval(); | ||
| decoder->nReset = 0; | ||
| decoder->eval(); | ||
| decoder->clk = 1; | ||
| decoder->eval(); |
Member
There was a problem hiding this comment.
You also miss the test for 0 where the selector will return 0.
|
|
||
| //test for addresses 1 to 20 | ||
| for (int address = 1; address <= 3; ++address) { | ||
| int expected_sel = 1 << (address - 1); |
rishyak
requested changes
Feb 21, 2024
Member
rishyak
left a comment
rishyak
left a comment
There was a problem hiding this comment.
Will be merged when it is cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.